This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(ethers-contract): Make ethers-providers optional #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
commented
Aug 5, 2023
There was a problem hiding this comment.
Content from ethers-contract/src/multicall/mod.rs was moved here. Nothing else was changed.
oblique
commented
Aug 5, 2023
ethers-contract/src/event_core.rs
Outdated
There was a problem hiding this comment.
Content from ethers-contract/src/event.rs was moved here. Nothing else was changed.
|
The tests that are failing are not related to my changes and they failing before the changes on my machine. |
|
I found that foundry was responsible for the test failures. The tests are passing with version |
oblique
force-pushed
the
feat/opt-providers
branch
from
e249352
to
3740d34
Compare
|
With the latest foundry nightly the tests passed, so this PR is ready. Any comments are welcome. |
zvolin
reviewed
Aug 8, 2023
DaniPopes
suggested changes
Aug 17, 2023
DaniPopes
approved these changes
Aug 18, 2023
zvolin
added a commit
to zvolin/ethereum-canister
that referenced
this pull request
Aug 18, 2023
oblique
pushed a commit
to eigerco/ethereum-canister
that referenced
this pull request
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm working in a very restricted WASM environment (see #2532), which I can not use
ethers-providerscrate. However I would like to useethers_contract::EthCallderive functions.Solution
With this PR, I introduced the
providersflag inethers-contract,ethers-contract-abigen, andethers-contract-derive. Anything related toethers-providersis now enabled with the flag.providersflag was added in the default features ofethers-contract.If a user adds
ethersorethers-middlewarecrates, thenprovidersis always enabled, even if user disabled the default flags. This is because they haveethers-providersas a dependency and there is no reason to make the flag optional.If a user adds
ethers-contractand disables default features, then they need to addprovidersfeature to get the same functionality as before. - Is this edge case a major breaking change?If you have any other ideas how this can be better, let me know.
PR Checklist